pkg-config: add <includedir>/libzrtcpp to CFLAGS#17
Open
tmatth wants to merge 1 commit intowernerd:masterfrom
Open
pkg-config: add <includedir>/libzrtcpp to CFLAGS#17tmatth wants to merge 1 commit intowernerd:masterfrom
tmatth wants to merge 1 commit intowernerd:masterfrom
Conversation
Author
|
Fixes issue #16 |
Also remove broken lines that are not required.
|
LGTM. |
Owner
|
This fix will be in the next release. Werner Am 11.01.2015 um 14:59 schrieb Peter Wu:
Werner Dittmann |
|
This patch does not seem right:
I think it would be much better to internally include all headers using #include "libzrtpcpp/xxx.h", and only allow users of this library to use #include <libzrtpcpp/xxx.h>, and not modify cflags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove broken lines that are not required.